Skip to content

Conversation

@dahlbyk
Copy link
Contributor

@dahlbyk dahlbyk commented Dec 24, 2017

Griddle major version

1.11

Changes proposed in this pull request

Fixes #781 root cause (cc @sum32)

  1. Includes first commit from Reconcile reducer/reducers #783.
  2. Added tests for GRIDDLE_UPDATE_STATE and adjusted its behavior a bit (e.g. not losing data).
  3. Updated actions.updateState to pass all state through, instead of only data, pageProperties and sortProperties. That limitation was introduced by @joellanciaux way back in Controlled Griddle component #505, but it's not obvious why.
  4. Added a story with a minimal repro (changing a <Griddle /> prop), which I ultimately expanded to demonstrate changing several <Griddle /> props, including data and styleConfig.

Why these changes are made

Changes to props should be reflected in Griddle's store and its rendering.

Are there tests?

Tests and stories!

Copy link
Member

@ryanlanciaux ryanlanciaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you

@ryanlanciaux ryanlanciaux merged commit 1aa0ec8 into GriddleGriddle:master Dec 24, 2017
@ryanlanciaux
Copy link
Member

Verified (smoke test on some of my bigger projects) and published!

image

@dahlbyk dahlbyk deleted the gh781 branch December 24, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants